-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: way for amp-instagram embeds to resize themselves #5032
Comments
@jasti Here's the issue mentioned on our call. Let us know if you have any questions or need any other details. Thanks! |
To fix this we'd need a contact with instagram. |
I've let Instagram know. |
Any updates on this one? :) |
/cc @adewale |
Sorry but we haven't made any progress with the Instagram folks. I'll ping them again. |
Has this one hit a dead-end? I'd love to have this one resolved, as we too have large amounts of Instagram-embedded content without image dimension data, so we're currently forced to assume a worst-case portrait aspect ratio, or suffer scroll bars. |
I took a look and instagram is sending the data already (Test case http://output.jsbin.com/tozokoj/quiet See console). So, this would be a simple change to amp-instagram.js |
Am I right in thinking this component would have to be wrapped in a 3p iframe ala Twitter/Facebook in order to properly map the messages to the specific embed instance? I might make an attempt at implementing this one... |
@src-code Nope, no need for major changes. Just install a postMessage receiver from the current component (similar to amp-youtube and other video player) and handle the message they are sending. |
Ok, took a stab at implementing this one (#7705), would love feedback! |
Closed by #7705. |
Please walk through the following steps for reporting an issue about AMP:
Instagram embeds that contain height bigger than the default will overflow with a scrollbar.
It would be nice if it could resize itself after loading.
Unfortunately, we don't store the dimensions of the image on our CMS ahead of time, and loading them on a per-request basis is too expensive.
How do we reproduce the issue?
Here is an example of embed that causes the effect:
The text was updated successfully, but these errors were encountered: