amp-instagram: Resizing in response to messages posted by iframe #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
reviewed
Feb 22, 2017
| if (this.iframe_./*OK*/offsetHeight !== height) { | ||
| // Height returned by Instagram includes header, so | ||
| // subtract 48px top padding | ||
| this.attemptChangeHeight(height - PADDING_TOP).catch(() => {}); |
There was a problem hiding this comment.
Probably OK to call changeHeight
aghassemi
suggested changes
Feb 22, 2017
| @@ -120,6 +126,10 @@ class AmpInstagram extends AMP.BaseElement { | |||
| layoutCallback() { | |||
| const iframe = this.element.ownerDocument.createElement('iframe'); | |||
| this.iframe_ = iframe; | |||
|
|
|||
| this.win.addEventListener( | |||
| 'message', event => this.handleInstagramMessages_(event)); | |||
There was a problem hiding this comment.
Let's keep a reference to the unlisten function so we remove the listener in unlayout e.g.
(listen is a utility function that can be imported from ../../../src/event-helper)
this.unlistenMessage_ = listen(this.win, 'message', this.handleInstagramMessages_.bind(this));
then in unlayout
if (this.unlistenMessage_) {
this.unlistenMessage_();
}
There was a problem hiding this comment.
Sounds good, I'll add that!
jridgewell
reviewed
Feb 22, 2017
| } | ||
| if (data.type == 'MEASURE') { | ||
| const height = data.details.height; | ||
| if (this.iframe_./*OK*/offsetHeight !== height) { |
There was a problem hiding this comment.
Does this need to be in vsync?
There was a problem hiding this comment.
Makes sense to be in vsync. attemptChangeHeight does its own mutate so I think we can do the check and the attemptChangeHeight in the same measure block. e.g.:
const height = data.details.height;
this.getVsync().measure(() => {
if (this.iframe_./*OK*/offsetHeight !== height) {
this.attemptChangeHeight(height - PADDING_TOP).catch(() => {});
}
});
jridgewell
approved these changes
Feb 24, 2017
aghassemi
approved these changes
Feb 24, 2017
| @@ -55,6 +62,9 @@ class AmpInstagram extends AMP.BaseElement { | |||
|
|
|||
| /** @private {?string} */ | |||
| this.shortcode_ = ''; | |||
|
|
|||
| /** @private {?function} */ | |||
adelinamart
pushed a commit
that referenced
this pull request
Mar 1, 2017
* Resizing in response to messages posted by Instagram iframe * Fixing lint errors * Adding listen/unlisten and use of getVsync * Fixing type check
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…project#7705) * Resizing in response to messages posted by Instagram iframe * Fixing lint errors * Adding listen/unlisten and use of getVsync * Fixing type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the automatic resize of the
amp-instagramcomponent in response to messages received from the Instagram iframe. Instagram posts messages with the following data property:Fixes issue #5032.