Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP Form Flake #5775

Closed
jridgewell opened this issue Oct 24, 2016 · 1 comment
Closed

AMP Form Flake #5775

jridgewell opened this issue Oct 24, 2016 · 1 comment
Assignees
@mkhatib
Labels
Related to: Flaky Tests
Milestone
To be deprecated ...

Comments

@jridgewell
Copy link
Contributor 

Chromium 51.0.2704 (Ubuntu 0.0.0) amp-form should allow rendering responses through templates FAILED
    AssertionError: expected null not to be null
        at doAsserterAsyncAndAddThen (/home/travis/build/ampproject/amphtml/node_modules/chai-as-promised/lib/chai-as-promised.js:292:33)
        at .<anonymous> (/home/travis/build/ampproject/amphtml/node_modules/chai-as-promised/lib/chai-as-promised.js:282:25)
        at get (/home/travis/build/ampproject/amphtml/node_modules/chai/chai.js:5396:37)
        at /tmp/c4798cd841690771cc0b2346e973d8e6.browserify:38735:43 <- /home/travis/build/ampproject/amphtml/extensions/amp-form/0.1/test/test-amp-form.js:451:42
@jridgewell
Copy link
Contributor Author

Ha, this is because I made timer code run faster.

jridgewell added a commit to jridgewell/amphtml that referenced this issue Oct 24, 2016
@jridgewell
Temp fix amp-form tests
88db825 
Re: ampproject#5775
jridgewell added a commit that referenced this issue Oct 24, 2016
@jridgewell
Remove Timer promises catch clause (#5758)
151a343 
* Remove Timer promises catch clause

Timer's promises can only fail because of being unable to schedule.

* Temp fix amp-form tests

Re: #5775
@jridgewell jridgewell mentioned this issue Oct 24, 2016
Closed
@mkhatib mkhatib mentioned this issue Oct 26, 2016
Merged
@ericlindley-g ericlindley-g added this to the Current milestone Oct 26, 2016
Lith pushed a commit to Lith/amphtml that referenced this issue Dec 22, 2016
@jridgewell
Remove Timer promises catch clause (ampproject#5758)
ce9c721 
* Remove Timer promises catch clause

Timer's promises can only fail because of being unable to schedule.

* Temp fix amp-form tests

Re: ampproject#5775
Lith pushed a commit to Lith/amphtml that referenced this issue Dec 22, 2016
@jridgewell
Remove Timer promises catch clause (ampproject#5758)
cba90f6 
* Remove Timer promises catch clause

Timer's promises can only fail because of being unable to schedule.

* Temp fix amp-form tests

Re: ampproject#5775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkhatib mkhatib

Labels
Related to: Flaky Tests
Projects
None yet
Milestone
To be deprecated - Current
Development

No branches or pull requests
3 participants
@mkhatib @jridgewell @ericlindley-g