Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor amp-sidebar tests to move event-dispatching to an integration test #6593

Closed
mkhatib opened this issue Dec 9, 2016 · 4 comments
Closed

Refactor amp-sidebar tests to move event-dispatching to an integration test #6593

mkhatib opened this issue Dec 9, 2016 · 4 comments
Assignees
@cathyxz
Labels
P3: When Possible Related to: Flaky Tests Type: Bug
Milestone
Backlog Bugs

Comments

@mkhatib
Copy link
Contributor

mkhatib commented Dec 9, 2016

amp-sidebar tests depends on firing events which might not be a good place for a unit test so possibly move this to an integration tests or remove dependency of events from unit tests
@mkhatib mkhatib added this to the Backlog milestone Dec 9, 2016
@mkhatib mkhatib mentioned this issue Dec 9, 2016
Merged
@mkhatib mkhatib removed their assignment Feb 7, 2017
@adelinamart
Copy link
Contributor

@camelburrito is this still an issue? Thanks

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @camelburrito Do you have any updates?

1 similar comment
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @camelburrito Do you have any updates?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@aghassemi aghassemi assigned cathyxz and unassigned aghassemi Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cathyxz cathyxz

Labels
P3: When Possible Related to: Flaky Tests Type: Bug
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
7 participants
@mkhatib @camelburrito @cathyxz @aghassemi @ampprojectbot @adelinamart @ampwafflebot