Fix Sidebar navigations being cancelled. #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested changes
Dec 9, 2016
| this.close_(); | ||
| const tgtLoc = parseUrl(target.href); | ||
| const curLoc = parseUrl(this.getAmpDoc().win.location.href); | ||
| const tgtHref = `${tgtLoc.origin}${tgtLoc.pathname}${tgtLoc.search}`; |
There was a problem hiding this comment.
Instead compare removeFragment(a.href) == removeFragment(b.href)
There was a problem hiding this comment.
Done. Should i keep the check for tgt.hash still or just close if the navigation is not to a new page? I think it's not entirely needed but a bit safer and we can relax it moving forward.
mkhatib
commented
Dec 9, 2016
| @@ -282,11 +282,91 @@ describe('amp-sidebar', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should reflect state of the sidebar', () => { | |||
There was a problem hiding this comment.
Not sure why github thinks I added this 😩
There was a problem hiding this comment.
I think the git diff just messed up
|
Added tests PTAL 👀 |
camelburrito
reviewed
Dec 9, 2016
| }, | ||
| }; | ||
| }); | ||
| anchor.dispatchEvent ? |
There was a problem hiding this comment.
not blocking you on this , may be we should move this to a integration test.
There was a problem hiding this comment.
Filed #6593 to refactor this in future
camelburrito
approved these changes
Dec 9, 2016
erwinmombay
pushed a commit
that referenced
this pull request
Dec 9, 2016
jridgewell
pushed a commit
that referenced
this pull request
Dec 9, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6585