Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-bind: Change number of slides in amp-carousel #8921

Closed
dreamofabear opened this issue Apr 24, 2017 · 1 comment
Closed

amp-bind: Change number of slides in amp-carousel #8921

dreamofabear opened this issue Apr 24, 2017 · 1 comment
Assignees
@kmh287
Labels
P3: When Possible
Milestone
New FRs

Comments

@dreamofabear
Copy link

Would be nice for the e-commerce use case, e.g. different product SKUs have a different number of detail images.

Some possibilities, in rough order of preference:

  • Use [class] binding to show/hide nested images and change amp-carousel to ignore hidden images.
  • Add new [slides] binding to amp-carousel that changes the max number of displayed slides.
  • Use amp-mustache to template the contents of the carousel, and have carousel update on re-render

/cc @kmh287
@dreamofabear dreamofabear added this to the New FRs milestone Apr 24, 2017
@kmh287 kmh287 self-assigned this Apr 25, 2017
@kmh287 kmh287 mentioned this issue Apr 25, 2017
Closed
@dreamofabear dreamofabear mentioned this issue May 3, 2017
Closed
@dreamofabear
Copy link
Author

Closing in favor of #9045.

@dreamofabear dreamofabear mentioned this issue Oct 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmh287 kmh287

Labels
P3: When Possible
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
3 participants
@kmh287 @dreamofabear @ampwafflebot