Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-carousel: Dynamic slide content #9045

Closed
ericlindley-g opened this issue Apr 28, 2017 · 6 comments
Closed

amp-carousel: Dynamic slide content #9045

ericlindley-g opened this issue Apr 28, 2017 · 6 comments
Assignees
@sparhami
Labels
Component: amp-carousel P3: When Possible Stale Inactive for one year or more Type: DevX issues impacting developer experience Type: Feature Request WG: components
Milestone
New FRs

Comments

@ericlindley-g
Copy link
Contributor

No description provided.

@ericlindley-g ericlindley-g added this to the Sprint H1 May milestone Apr 28, 2017
@dreamofabear
Copy link

dreamofabear commented May 9, 2017 •
edited
Loading

Two things to do:

  • Add support to amp-carousel to handle children with dynamic contents (e.g. amp-list, template)
  • Add support to amp-list to use amp-state as render data source

Context: Design review doc, #8900 (comment)

@dreamofabear dreamofabear changed the title amp-carousel dynamic add/remove slide design amp-carousel: Dynamic slide content May 9, 2017
@dreamofabear dreamofabear mentioned this issue May 9, 2017
Closed
@dreamofabear dreamofabear modified the milestones: New FRs, Sprint H1 May May 11, 2017
@dreamofabear
Copy link

Moving to "New FRs" pending triage.

@dreamofabear
Copy link

/cc @kmh287

@kmh287 kmh287 removed their assignment Jun 15, 2017
@aghassemi
Copy link
Contributor

amp-carousel v2 and amp-script are designed with this in mind.

@aghassemi aghassemi assigned sparhami and unassigned aghassemi Jun 21, 2019
@aghassemi aghassemi added Component: amp-carousel Type: DevX issues impacting developer experience labels Jun 23, 2019
@stale
Copy link

stale bot commented Dec 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 29, 2020
@micajuine-ho
Copy link
Contributor

This has been addressed in amp-carousel v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparhami sparhami

Labels
Component: amp-carousel P3: When Possible Stale Inactive for one year or more Type: DevX issues impacting developer experience Type: Feature Request WG: components
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
7 participants
@camelburrito @sparhami @aghassemi @kmh287 @ericlindley-g @dreamofabear @micajuine-ho