Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error compiling extensions/amp-sticky-ad/1.0/amp-sticky-ad.js #9325

Closed
lannka opened this issue May 13, 2017 · 5 comments · Fixed by #9587
Closed

Error compiling extensions/amp-sticky-ad/1.0/amp-sticky-ad.js #9325

lannka opened this issue May 13, 2017 · 5 comments · Fixed by #9587
Assignees
@zhouyx
Labels
WG: infra WG: monetization
Milestone
Sprint H2 May

Comments

@lannka
Copy link
Contributor

lannka commented May 13, 2017

Build flaky:

Error compiling extensions/amp-sticky-ad/1.0/amp-sticky-ad.js
ENOENT: no such file or directory, open 'build/cc/extensions_amp-sticky-ad_1.0_amp-sticky-ad.js'
@lannka lannka added this to the Sprint H2 May milestone May 13, 2017
@aghassemi aghassemi mentioned this issue May 16, 2017
Merged
@zhouyx zhouyx modified the milestones: FIXIT I/O Week, Sprint H2 May May 16, 2017
@zhouyx
Copy link
Contributor

zhouyx commented May 16, 2017

Should be related to #9042. I am thinking there's a race condition here on whether amp-sticky-ad-0.1 or amp-sticky-ad-1.0 gets built first. @erwinmombay Would you please take a look, I am pretty confused 😢

@zhouyx
Copy link
Contributor

zhouyx commented May 16, 2017

https://travis-ci.org/ampproject/amphtml/builds/231656087

@lannka lannka mentioned this issue May 18, 2017
Merged
@lannka
Copy link
Contributor Author

lannka commented May 25, 2017

We don't need to compile the same binary twice. Let's just copy 1.0 to 0.1 as an alias.

@zhouyx zhouyx mentioned this issue May 26, 2017
Merged
@rsimha
Copy link
Contributor

rsimha commented Jun 1, 2017

This issue is causing master to go red today. Taking a look.

@rsimha rsimha self-assigned this Jun 1, 2017
@rsimha
Copy link
Contributor

rsimha commented Jun 1, 2017

Just noticed that @zhouyx is already working on this in #9587, so re-assigning.

@rsimha rsimha removed their assignment Jun 1, 2017
@zhouyx zhouyx removed the Type: Bug label Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

Labels
WG: infra WG: monetization
Projects
None yet
Milestone
Sprint H2 May
Development

Successfully merging a pull request may close this issue.

Copy and rename compiled script directly for deprecated version zhouyx/amphtml
4 participants
@erwinmombay @zhouyx @lannka @rsimha