Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up travis build #9403

Merged
merged 5 commits into from
May 18, 2017
Merged

Speed up travis build #9403

merged 5 commits into from
May 18, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 17, 2017

This PR attempts to speed up the travis build for PRs and pushes to master by sharding the various build and test tasks into separate, independent sets of tasks that are run in parallel.

Fixes #9387

@rsimha rsimha requested a review from lannka May 17, 2017 22:36
@rsimha rsimha self-assigned this May 17, 2017
@rsimha rsimha modified the milestone: FIXIT I/O Week May 17, 2017
@lannka
Copy link
Contributor

lannka commented May 18, 2017

@rsimha-amp you can revert the last commit, and it should pass the test:
https://travis-ci.org/ampproject/amphtml/builds/233460194?utm_source=github_status&utm_medium=notification

was flaky due to #9325

@rsimha
Copy link
Contributor Author

rsimha commented May 18, 2017

@lannka: Nice! Looks like the overall build time has been halved. I've reverted the last commit, and this is now ready for review.

timedExecOrDie(`${gulp} clean`);
timedExecOrDie(`${gulp} lint`);
},
buildRuntime: function() {
timedExecOrDie(`${gulp} clean`);
timedExecOrDie(`${gulp} build`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theoretically, we don't need gulp build. gulp build --css-only should be enough.
i know it might fail some tests right now, can we add a TODO to investigate later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function (buildRuntime) is called before the unit tests and the integration tests. I've already added a TODO to investigate why the unit tests currently need this function to be called. So this is done, I believe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine. I think integration should not need that either.

@rsimha rsimha merged commit f62a93d into ampproject:master May 18, 2017
@rsimha rsimha deleted the 2017-05-17-ParallizeTravisBuild branch May 18, 2017 05:12
@rsimha rsimha mentioned this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants