-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up travis build #9403
Speed up travis build #9403
Conversation
@rsimha-amp you can revert the last commit, and it should pass the test: was flaky due to #9325 |
@lannka: Nice! Looks like the overall build time has been halved. I've reverted the last commit, and this is now ready for review. |
timedExecOrDie(`${gulp} clean`); | ||
timedExecOrDie(`${gulp} lint`); | ||
}, | ||
buildRuntime: function() { | ||
timedExecOrDie(`${gulp} clean`); | ||
timedExecOrDie(`${gulp} build`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theoretically, we don't need gulp build
. gulp build --css-only
should be enough.
i know it might fail some tests right now, can we add a TODO to investigate later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function (buildRuntime) is called before the unit tests and the integration tests. I've already added a TODO to investigate why the unit tests currently need this function to be called. So this is done, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine. I think integration should not need that either.
This PR attempts to speed up the travis build for PRs and pushes to master by sharding the various build and test tasks into separate, independent sets of tasks that are run in parallel.
Fixes #9387