♻️Cleanup FxProvider's private fields #14804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nainar
approved these changes
Apr 23, 2018
jridgewell
force-pushed
the
fx-provider-cleanup
branch
from
ab0f280
to
4cfd087
Compare
- `ampdoc_` appears unused, - `initialize_` is called externally (meaning it's really public) - Additionally, it's only ever called after construction, so why isn't it just in the constructor?
It's accessed from outside the class, meaning it's public.
jridgewell
force-pushed
the
fx-provider-cleanup
branch
from
4cfd087
to
02c410e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ampdoc_appears unused,initialize_is called externally (meaning it's really public)it just in the constructor?
adjustedViewportHeight_is called externally (meaning it's really public)Part of #14761.