Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Delayed force-exit gulp test after Karma reports test completion #14814

Merged
merged 2 commits into from
Apr 23, 2018
Merged

🐛 Delayed force-exit gulp test after Karma reports test completion #14814

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4306b1
Delayed force-exit the gulp test process after Karma reports test com…
rsimha Apr 23, 2018
b6e525c
Add issue
rsimha Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-system/tasks/runtime-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,10 @@ function runTests() {
log(
red('ERROR:'),
yellow('Karma test failed with exit code ' + exitCode));
process.exitCode = exitCode;
// TODO(rsimha): Remove this after Karma / Sauce ticket is resolved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably link to issues here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

setTimeout(() => {
process.exit(exitCode);
}, 5000);
}
resolver();
}).on('run_start', function() {
Expand Down