Ramp up amp-img-native-srcset experiment to 1% #15200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
May 10, 2018
aghassemi
reviewed
May 10, 2018
| @@ -33,5 +33,6 @@ | |||
| "expUnconditionedAdxIdentity": 0.01, | |||
| "expUnconditionedDfpIdentity": 0.01, | |||
| "expUnconditionedCanonicalHoldback": 0.01, | |||
| "amp-consent": 1 | |||
| "amp-consent": 1, | |||
| "amp-img-native-srcset": 1 | |||
There was a problem hiding this comment.
/cc @erwinmombay Does Canary config differing from Prod config actually work? ( I don't remember ever doing this in the past. It does make sense for us to do this here, just want to make sure it actually does something)
There was a problem hiding this comment.
I think per this documentation, canary-config.json is actually just 1% of production, so for 1%, we can just opt in all of canary and leave production alone.
There was a problem hiding this comment.
yeah Canary always goes to 1% of production on or around Wednesdays anyway. it is fine to keep what you have. May endup being ~1.5%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ramp up
amp-img-native-srcsetexperiment to 100% of canary and 1% of production. Related to #11575.