🏗 Refactor lint.js and update jsdoc/check-tag-names rule
#15298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
changed the title
jsdoc/check-tag-names rulejsdoc/check-tag-names rule; Refactor lint.js
rsimha
changed the title
jsdoc/check-tag-names rule; Refactor lint.jslint.js and update jsdoc/check-tag-names rule
dreamofabear
approved these changes
May 15, 2018
| * | ||
| * @return {boolean} | ||
| */ | ||
| function eslintrcChangesInPr() { |
There was a problem hiding this comment.
Consider checking that this is a PR build inside this function instead.
There was a problem hiding this comment.
The check for a PR build needs to be outside because it's also used when .eslintrc is not in the list of files.
There was a problem hiding this comment.
On second thought, good idea. Done.
build-system/tasks/lint.js
Outdated
| /** | ||
| * Enables linting in strict mode. | ||
| */ | ||
| function enableStrictMode() { |
build-system/tasks/lint.js
Outdated
| * | ||
| * @param {!Array<string>} files | ||
| */ | ||
| function setFiles(files) { |
build-system/tasks/lint.js
Outdated
| */ | ||
| function setFiles(files) { | ||
| config.lintGlobs = | ||
| config.lintGlobs.filter(e => e !== '**/*.js').concat(files); |
There was a problem hiding this comment.
Do you want to check paths that end with **/*.js instead of strictly matching?
There was a problem hiding this comment.
This works because there's only one positive glob in config.lintGlobs:
amphtml/build-system/config.js
Lines 119 to 134 in 5088f70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
jsdoc/check-tag-namesrulelint.jsso that:.eslintrcis changedFollow up to #15294
Follow up to #15256
Partial fix for #15255