-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't lint the eslint-rules directory #15397
Conversation
Oh, the irony
build-system/eslint-rules/.eslintrc
Outdated
"jsdoc/require-param": 0, | ||
"jsdoc/require-param-name": 0, | ||
"jsdoc/require-param-type": 0, | ||
"jsdoc/require-returns-type": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No trailing commas in .eslintrc
.
build-system/eslint-rules/.eslintrc
Outdated
"jsdoc/require-param-type": 0, | ||
"jsdoc/require-returns-type": 0, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update PR description to reflect this change.
|
Oh, I figured it out. Add amphtml/build-system/eslint-rules/index.js Lines 22 to 23 in a22e4eb
|
Turns out a few more changes are needed here. I'm working on a PR. Edit: Sent out #15426, which closes this PR. |
Also bumps a copyright year. #15204 (comment)