Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint the eslint-rules directory #15397

Closed
wants to merge 3 commits into from
Closed

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented May 17, 2018

Also bumps a copyright year. #15204 (comment)

@jridgewell jridgewell requested a review from rsimha May 17, 2018 18:01
"jsdoc/require-param": 0,
"jsdoc/require-param-name": 0,
"jsdoc/require-param-type": 0,
"jsdoc/require-returns-type": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No trailing commas in .eslintrc.

"jsdoc/require-param-type": 0,
"jsdoc/require-returns-type": 0,
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PR description to reflect this change.

@jridgewell jridgewell changed the title Update copyright year Don't lint the eslint-rules directory May 18, 2018
@rsimha
Copy link
Contributor

rsimha commented May 18, 2018

If that didn't work, just ignore the entire directory in lintGlobs. We can use https://www.npmjs.com/package/eslint-plugin-eslint-plugin to lint the eslint-rules directory.

@rsimha
Copy link
Contributor

rsimha commented May 18, 2018

Oh, I figured it out. Add .eslintrc to the list of files that don't belong in ruleFiles here, and you should be fine.

const ruleFiles = fs.readdirSync(__dirname).filter(ruleFile =>
!['index.js', 'node_modules', 'package.json'].includes(ruleFile));

@rsimha
Copy link
Contributor

rsimha commented May 18, 2018

Turns out a few more changes are needed here. I'm working on a PR.

Edit: Sent out #15426, which closes this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants