Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AMP_STATE() URL variable that reads from the amp-bind state #15427

Merged
merged 8 commits into from
May 22, 2018

Conversation

josh313
Copy link
Contributor

@josh313 josh313 commented May 18, 2018

@dreamofabear dreamofabear self-requested a review May 18, 2018 19:12
@dreamofabear
Copy link

Thanks for working on this.

Perhaps we should limit these expressions to only object dereferences, e.g. x.y.z not random(). We have a function helper for this in json.js#getValueForExpr(), which is also nice since we won't need to have a web worker roundtrip.

@josh313
Copy link
Contributor Author

josh313 commented May 22, 2018

@choumx I updated it to use the getValueForExpr now. Thanks for the suggestion.

I'm getting a bundle size error now. What should I do about that?

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably due to the new code in url-replacements-impl. I helped bump the size cap, should be good now.

@dreamofabear dreamofabear merged commit ac174d3 into ampproject:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants