🐛 Re-enable Safari on Sauce labs

[rsimha]

From Sauce Labs Help Center:

We've done some fixes on our backend that might help with the current behavior you're seeing.
Could you try running your suite again and tell us if you see any improvement on the error rate?
If you don't please send us any console logs and build links so we can have a closer look.

Fixes #14848

[rsimha]

/to @choumx

I'll re-rerun Travis a few times to see if this is indeed fixed.

[rsimha]

Trying the fix in https://support.saucelabs.com/hc/en-us/articles/115010079868

@erwinmombay Since Safari doesn't play well with the localhost name, the suggestion is for karma to use a different hostname like 127.0.0.1. Any idea how to get our tests to play well with this? I tried browserify-replace, but there's no way to reliably fix all instances of hardcoded localhost in our tests.

Does this mean we're effectively unable to test on Safari?

Results should show up in https://travis-ci.org/ampproject/amphtml/builds/383459381

[rsimha]

@choumx This has passed three times. Latest run: https://travis-ci.org/ampproject/amphtml/builds/383874710

I've re-enabled Safari for unit tests, and Safari and Android browser for integration tests. Looking good after multiple tries.

The iphone config seems to have changed, so I'll enable that in a separate PR.

Merging (fingers crossed)...

[lannka]

hostname: process.platform === 'darwin' ? '127.0.0.1' : 'localhost',

This change broke test-amp-analytics.js when running locally, where some tests are doing URL comparison with http://localhost/ .

Having this discrepancy between environments can be a bug hole. Can we unify to 127.0.0.1 for instance?

[dreamofabear]

This also breaks test-impression.js locally.

FAILED TESTS:
  impression
    clickUrl
      ● should replace location href only with query params
        HeadlessChrome 0.0.0 (Mac OS X 10.13.4)
      AssertionError: expected 'http://127.0.0.1:9876/context.html?bar=foo&test=4321&gclid=123456&foo=bar&example=123' to equal 'http://localhost:9876/context.html?bar=foo&test=4321&gclid=123456&foo=bar&example=123'
          at /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/test/functional/test-impression.js:264:40 <- /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/aa74d3bbeb793a22ab3bc8e8dbdee15b.browserify:73683:41

    replaceUrl
      ● should use init replaceUrl parm if viewer has no capability
        HeadlessChrome 0.0.0 (Mac OS X 10.13.4)
      AssertionError: expected 'http://127.0.0.1:9876/context.html?bar=foo&test=4321&gclid=123456&foo=bar&example=123' to equal 'http://localhost:9876/v/s/f.com/?gclid=1234&amp_js_v=1&init'
          at /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/test/functional/test-impression.js:291:40 <- /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/aa74d3bbeb793a22ab3bc8e8dbdee15b.browserify:73721:41

      ● should replace location href with replaceUrl from viewer
        HeadlessChrome 0.0.0 (Mac OS X 10.13.4)
      AssertionError: expected 'http://127.0.0.1:9876/context.html?bar=foo&test=4321&gclid=123456&foo=bar&example=123?bar=foo&test=4321#hash' to equal 'http://localhost:9876/v/s/f.com/?gclid=1234&amp_js_v=1#hash'
          at /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/test/functional/test-impression.js:339:40 <- /var/folders/xy/zdjxmyvn1vjg75zhtgc5r28h006wch/T/aa74d3bbeb793a22ab3bc8e8dbdee15b.browserify:73779:41