✨🏗 Add expectAsyncConsoleError
, which enables tests to check for async errors
#15621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allowConsoleError
construct lets you capture synchronous calls toconsole.error
in a test, and indicate that they are expected and that the test shouldn't fail. However, when test code results in asynchronous errors, there's no good way to useallowConsoleError
as written today.This PR does the following:
expectAsyncConsoleError
, which lets you specify that a given asynchronousconsole.error
is expected at some point during the test.expectAsyncConsoleError
annotation to all tests inextensions/amp-analytics/0.1/test/test-amp-analytics.js
that were resulting in async errorsFixes #15609
Required for #14406