Resolve relative URL #1629
Merged
Resolve relative URL #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const prefix = path[1]; | ||
| assert(prefix == 'c' || prefix == 'v', | ||
| 'Unknown path prefix in url %s', url.href); | ||
| const domainOrHttpsSignal = path[2]; |
There was a problem hiding this comment.
No chance to share some code with getSourceOrigin?
There was a problem hiding this comment.
Ok. I redefined getSourceOrigin via getSourceUrl. Initially I wanted to avoid an extra parse, but I think that's negligible.
|
@cramforce PTAL. I'm now using |
dvoytenko
force-pushed
the
url-resolve
branch
3 times, most recently
from
2bf0c91 to
9e100ae
Compare
dvoytenko
force-pushed
the
url-resolve
branch
from
9e100ae to
38abef8
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.