-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause/Resume and Layout/Unlayout callbacks #1637
Pause/Resume and Layout/Unlayout callbacks #1637
Conversation
793eeb5
to
388fd0e
Compare
73be9a0
to
e9a23b1
Compare
1c8b8b9
to
7399177
Compare
It passed Travis!!! 🎆🎊 |
* || documentInactiveCallback may be called N times after this. | ||
* || pauseCallback may be called N times after this. | ||
* || resumeCallback may be called N times after this. | ||
* || unlayoutCallback may be called N times after this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlayout before layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to only be called if LAYOUT_COMPLETE
.
@jridgewell to confirm, as discussed offline, let's do the PR where we add |
Yup. |
59e82d6
to
f102c53
Compare
f102c53
to
9bcae59
Compare
d04ed7c
to
1c237c3
Compare
Once Travis passes, I'll merge. |
e3b89ca
to
c975e8b
Compare
c975e8b
to
1dbda46
Compare
Pause/Resume and Layout/Unlayout callbacks
First pass at separating
pauseCallback
fromunlayoutCallback
, which addsresumeCallback
to the mix.Fixes #2560.
Future PRs:
layoutCallback
calls into the state machine transitionsunlayoutCallback