Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Exclude ads/ and third_party/ from code coverage analysis #16442

Merged
merged 1 commit into from
Jun 28, 2018
Merged

🏗 Exclude ads/ and third_party/ from code coverage analysis #16442

merged 1 commit into from
Jun 28, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 28, 2018

The AMP unit tests don't explicitly cover these directories, so we should exclude them from the overall report as they skew the numbers.

Follow up to #16417 and #16432
Fixes #16396

@rsimha rsimha self-assigned this Jun 28, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Jun 28, 2018

/to @jpettitt @choumx

Copy link
Contributor

@jpettitt jpettitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsimha rsimha merged commit a4ec810 into ampproject:master Jun 28, 2018
@rsimha rsimha deleted the 2018-06-28-CoverageSkip branch June 28, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants