Disallow passing ampdoc to FIE service getters #19730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
force-pushed
the
no-ampdoc-fie-getter
branch
from
f7bf5a7
to
7d8d5b0
Compare
dreamofabear
force-pushed
the
no-ampdoc-fie-getter
branch
from
8f1d5dc
to
7e15c81
Compare
|
/to @jridgewell |
jridgewell
approved these changes
Dec 13, 2018
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
* Remove ampdoc for getting FIE services. * Remove deprecated service getter. * Remove unused FIE window service getter and inlined helper fn. * Simplify some comments. * Fix test-url-replacements.js. * Fix test-standard-actions.js. * Fix several more tests. * Fix lint. * Fix test-amp-form and test-amp-gwd-animation.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Remove ampdoc for getting FIE services. * Remove deprecated service getter. * Remove unused FIE window service getter and inlined helper fn. * Simplify some comments. * Fix test-url-replacements.js. * Fix test-standard-actions.js. * Fix several more tests. * Fix lint. * Fix test-amp-form and test-amp-gwd-animation.
This was referenced Oct 10, 2020
This was referenced Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #19602 to be merged.Partial for #16322.All FIE-supported services are already migrated off of ampdoc. This PR changes the signature/implementation of the underlying service getter to ensure that new FIE services won't be able to pass
AmpDoc. Also cleans up a few unused functions etc.Next:
getElementServiceForDoc).