✨New amp-cld-img extension to display assets from Cloudinary.

[nitzanj]

Add a new extension named amp-cld-img, used to display images from Cloudinary.
This is a completely new extension based on <img>, useful for Cloudinary customers authoring amp pages.

The extension allows developers to declare transformations and effects using attributes, and then sets the underlying src attribute automatically.

More info:
Intent to implement
Cloudinary home page

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[ghost]

This pull request introduces 2 alerts when merging d5c6c2a into b814e5d - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable
• 1 for Unneeded defensive code

---

Comment posted by LGTM.com

[aghassemi]

adding @sparhami as well to help out with the review. Thanks!

[sparhami]

Added some comments, will take another look once those are addressed.

[sparhami]

Since these keys are combined with those of responsive, it is a bit misleading to have them as separate objects. For example, just reading the code at a quick glance, there doesn't seem to be any problem if there are keys that are repeated between the two, when in fact, this is a problem.

It could make things more clear to have comments to separate out the sections:

const fields = {
  // transformations
  b: background,

  // responsive
  dpr: dprValue,
}

[nitzanj]

I agree it's a bit confusing, however the separation is there because each segment of the is processed separately - [raw_transformation/transformations fields/responsive fields].
It ends up looking like so (assuming no raw transformation, for simplicity):
b_red,e_sepia/w_100,c_crop
If all the fields are in the same object I can't really separate which fields come before the slash and which ones after, it can change the meaning completely.

[ghost]

This pull request introduces 2 alerts when merging 1b6e0cc into e38e621 - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable
• 1 for Unneeded defensive code

---

Comment posted by LGTM.com

[mrjoro]

Is this PR still active?

[mrjoro]

I'm closing this PR since it no longer seems active. Please reopen if needed.