🏗♻️🚮🐛 Refactor compile()
in build-system/tasks/helpers.js
#22254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, there is one giant function called
compile()
inbuild-system/tasks/helpers.js
that compiles the various AMP build targets in minified and unminified modes.This PR does the following:
checkTypes
option (added in Fix many, many type warnings. #3539, made obsolete by Type check first extension (amp-youtube) #4931)preventRemoveAndMakeDir
option (added in fix race deletions of polyfill folders to accomodate includePolyfill on more than just the main binary #2880, but never used asfalse
)compile()
intocompileAllMinifiedTargets()
andcompileAllUnminifiedTargets()
v0.js
andv0-esm.js
, thereby fixing the race in race between v0.js and v0-esm.js generation for closure #18934Follow up to #3539 and #4931
Follow up to #2880
Fixes #18934