Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗♻️🚮🐛 Refactor compile() in build-system/tasks/helpers.js #22254

Merged
merged 5 commits into from
May 10, 2019
Merged

🏗♻️🚮🐛 Refactor compile() in build-system/tasks/helpers.js #22254

merged 5 commits into from
May 10, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 10, 2019

Today, there is one giant function called compile() in build-system/tasks/helpers.js that compiles the various AMP build targets in minified and unminified modes.

This PR does the following:

Follow up to #3539 and #4931
Follow up to #2880
Fixes #18934

@rsimha rsimha requested a review from erwinmombay May 10, 2019 21:48
@rsimha rsimha self-assigned this May 10, 2019
@rsimha rsimha requested a review from jridgewell May 10, 2019 21:56
@rsimha
Copy link
Contributor Author

rsimha commented May 10, 2019

/to @erwinmombay @jridgewell

@rsimha
Copy link
Contributor Author

rsimha commented May 10, 2019

Tested gulp build --fortesting and gulp dist --fortesting, and made sure source maps are good when used with --full_sourcemaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

race between v0.js and v0-esm.js generation for closure
4 participants