Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🚮 Simplify the way gulp lint works on Travis #22294

Merged
merged 2 commits into from
May 14, 2019
Merged

🏗🚮 Simplify the way gulp lint works on Travis #22294

merged 2 commits into from
May 14, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 14, 2019

Over the past year, various lint rules were added to improve AMP's code correctness. For example, #14742, #12748, #15255, #14761. In addition, lint checks were enabled for the code in validator/, which is developed in a different repo and periodically synced to amphtml. See #18601 and #13966.

As a result, gulp lint is run only against the files edited by a PR during PR builds, while hundreds of linter warnings are printed during push builds.

This PR does the following:

Follow up tasks:

@rsimha rsimha requested a review from jridgewell May 14, 2019 20:01
@rsimha rsimha self-assigned this May 14, 2019
Copy link
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm validator

@rsimha
Copy link
Contributor Author

rsimha commented May 14, 2019

This is ready. Logs now show zero lint errors / warnings: https://travis-ci.org/ampproject/amphtml/jobs/532494203#L346-L350

I've also tested that running gulp lint --local-changes still works as originally designed.

Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint task change LGTM

@rsimha rsimha merged commit bd6e812 into ampproject:master May 14, 2019
@rsimha rsimha deleted the 2019-05-14-LintRules branch May 14, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants