🐛 Turn on the amphtml-internal/unused-private-field rule, fix errors
#22626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov spam was due to a bad configuration in |
erwinmombay
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15075 added a new lint rule called
amphtml-internal/unused-private-fieldto ensure that all private class fields are correctly annotated. Since then, the rule has sat around for a while in warning mode and then gotten turned off.This PR re-enables the rule and updates annotations that aren't supposed to be
@private.Note: Most of the annotations I've changed are obviously supposed to be
@protected,@restricted, or@visibleForTesting. However, a small handful of fields are either not being used anywhere, or are being exposed to external code in some way. In the interest of not touching code, I've gone ahead and marked them@protected. (/cc @jridgewell)Fixes #14742