Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require node to be always passed when resolving ampdoc #23098

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Require node to be always passed when resolving ampdoc #23098

merged 2 commits into from
Jun 28, 2019

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Jun 28, 2019 •
edited
Loading

Partial for #22734

dreamofabear
dreamofabear approved these changes Jun 28, 2019
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up.

@dvoytenko dvoytenko merged commit 13c141e into ampproject:master Jun 28, 2019
@dvoytenko dvoytenko deleted the ampdoc17 branch June 28, 2019 21:45
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Require node to be always passed when resolving ampdoc (ampproject#23098
6db443d 
)

* Require node to be always passed when resolving ampdoc

* fixing tests
@ampprojectbot ampprojectbot mentioned this pull request Aug 5, 2020
Closed
@ampprojectbot ampprojectbot mentioned this pull request Jul 28, 2021
Closed
@ampprojectbot ampprojectbot mentioned this pull request Dec 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoytenko @dreamofabear @googlebot