Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-img: Remove [srcset] when [src] is mutated #23779

Merged
merged 2 commits into from
Aug 7, 2019
Merged

amp-img: Remove [srcset] when [src] is mutated #23779

merged 2 commits into from
Aug 7, 2019

Conversation

dreamofabear
Copy link

Fixes #10207.

/to @cathyxz

@dreamofabear dreamofabear requested a review from cathyxz August 7, 2019 18:23
cathyxz
cathyxz approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@cathyxz cathyxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamofabear dreamofabear merged commit 2cf8cac into ampproject:master Aug 7, 2019
@dreamofabear dreamofabear deleted the bind-img-src branch August 7, 2019 20:04
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
amp-img: Remove [srcset] when [src] is mutated (ampproject#23779)
abe0b8b 
* Remove [srcset] if only [src] is mutated.

* Update amp-bind docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathyxz cathyxz cathyxz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-bind: Binding to amp-img[src] also requires [srcset] on cache
3 participants
@dreamofabear @cathyxz @googlebot