feature(amp-img): add amp-img fallback #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
changed the title
erwinmombay
force-pushed
the
fallback-img
branch
2 times, most recently
from
926bc87 to
8c9b067
Compare
|
@dvoytenko PTAL |
erwinmombay
force-pushed
the
fallback-img
branch
8 times, most recently
from
5fb5d41 to
bdd6c23
Compare
| /** @private {boolean} */ | ||
| this.allowImgLoadFallback_ = false; | ||
|
|
||
| // if this amp-img IS the fallback then don't allow it to have its own |
erwinmombay
force-pushed
the
fallback-img
branch
4 times, most recently
from
017fb6e to
d9c9acb
Compare
|
@dvoytenko PTAL |
| // Clean up the fallback if the src has changed. | ||
| if (!this.allowImgLoadFallback_ && | ||
| this.img_.classList.contains('-amp-ghost')) { | ||
| this.img_.classList.remove('-amp-ghost'); |
There was a problem hiding this comment.
vsync since we are out of phase here with a micro-task.
erwinmombay
force-pushed
the
fallback-img
branch
from
d9c9acb to
bdc6b5b
Compare
|
LGTM |
erwinmombay
added a commit
that referenced
this pull request
Mar 16, 2016
feature(amp-img): add amp-img fallback
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2335