✨amp-next-page v2 history manipulation #25971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wassgha
force-pushed
the
amp-next-page-v2-history
branch
from
7c1e4ee
to
37fe3f0
Compare
wassgha
requested review from
sparhami and
caroqliu
and removed request for
cathyxz
sparhami
suggested changes
Dec 16, 2019
sparhami
approved these changes
Dec 16, 2019
wassgha
force-pushed
the
amp-next-page-v2-history
branch
from
be24cae
to
1a2eaf4
Compare
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Added intial implementation of history manipulation on amp-next-page v2 * Added ability to go back to the initial page and fixed logic * Fixes type checks and adds og:image ot the initial page * Feedback from review * Switched to using an object instead of params in page.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25553
Changes
amp-next-pagev2 to change the title and url of the document based on the currently visible pageamp-next-pagev1, this adds an extra entry in the history so that the currently visible sub-page is given its own history entry (the user is now able to go back to the original page in history where as previously they could only go back to the last sub-page and information about the initial page is lost).pagesarray