✨ SwG: Propensity to Subscribe in AMP #26003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are in the middle of migrating all vendor config from js file to json file. The idea is that the config doesn't need to be compiled into the amp-analytics.js, instead AMP can load them lazily. Please also check in a json version of the vendor config file. You can do so by running Please refer to #26050 for more information on the migration process. |
jpettitt
approved these changes
Dec 20, 2019
|
Renamed it subscriptions-propensity for consistency with the rest of SwG. |
|
|
zhouyx
reviewed
Jan 2, 2020
extensions/amp-analytics/0.1/vendors/subsciptions-propensity.js
Outdated
Show resolved
Hide resolved
zhouyx
suggested changes
Jan 2, 2020
extensions/amp-analytics/0.1/vendors/subsciptions-propensity.js
Outdated
Show resolved
Hide resolved
sparhami
pushed a commit
to sparhami/amphtml
that referenced
this pull request
Jan 3, 2020
* Propensity to Subscribe in AMP * fix types in AMP * minor improvements, fix tests * use getSku, add propensity tests * generate new file format * subscriptions-propensity * finish rename * redo data parameter * change formatting * adjust expectations for new format * rename file * remove comments * change change variable coding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Propensity to Subscribe in AMP