✨ Add Sirdata to the list of supported CMPs in the amp-consent extension #26040
Conversation
- update amp consent documentation & code to reference sirdata CMP
- fix css typo for style .filterBar form *
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it!
Le lun. 16 déc. 2019 à 14:23, googlebot <notifications@github.com> a écrit :
… Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fampproject%2Famphtml%2Fpull%2F26040>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26040?email_source=notifications&email_token=AATE26BVVQRJNYX6JJJLCXDQY56NPA5CNFSM4J3J3CFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6V6SA#issuecomment-566058824>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATE26CCLADL4V2FKLZAHYLQY56NPANCNFSM4J3J3CFA>
.
--
<https://www.sirdata.com/>www.sirdata.com
RÉMI DEMOL - C.T.O.
+33 (0) 186 954 338
rde@sirdata.fr
20 rue Saint-Fiacre - 75002 Paris
<https://www.facebook.com/Sirdatagroup>
<https://twitter.com/SirdataGroup>
<https://www.linkedin.com/company/sirdata>
Sirdata recrute <https://www.welcometothejungle.co/companies/sirdata>
<https://www.welcometothejungle.co/companies/sirdata>
|
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thank you for the Pull Request! |
|
Another thing that I want to mention is we will no longer support the fullScreen API without user interaction. Please let us know if that works for your case. More details here. #26197 |
|
I don't reproduce the error. Can you provide more information about the request ? About the fullScreen API, we'll have to adjust our first screen to fit the maximum 60vh. |
There was a problem hiding this comment.
Looks great in general. Thank you for working around with our 60vh height restriction.
One thing to confirm with you is that: when I hit the close button on fullscreen, it leads me back to the following page instead of closing the prompt. Is that expected? Thank you
|
About the close button that leads back to the main screen instead of closing the prompt (only on the partners screen), it's indeed what it's expected by now. But since it might be confusing for users, we might change it. |
|
Thanks for the clarification on the close button. Yes I found it to be a bit confusing, but it's your final call on the UI behavior within the iframe. Could you please fix the |
|
This pull request introduces 1 alert when merging 7c7dbb7 into 6f79c36 - view on LGTM.com new alerts:
|
@zhouyx We removed the close button on the partners layout + all requested changes have been committed. Works for you ? Thanks |
|
Looks great! Thank you |
|
@tla-sirdata The travis check failed because of a dead link in the doc. I've created #26508 to fix it. Please sync to master again once that PR has been merged. Then I can proceed and merge this PR. Thank you very much. |
Thx! I merged from master |
|
@zhouyx It seems that there's still some failed checks. Let me know if we can help |
|
restarted visual test, and everything looks good now. PR merged. Thank you for the integration. |
|
Could you just tell me when it is in production ? Thank you for your help! |
|
The PR was merged on Wednesday, should be available for developer opt in sometime next Tuesday, and ship in prod the Tuesday afterwards. Here's our detailed schedule Thank you |
|
Got it ! Thank you |
ampprojectbot
added
PR use: In Beta / Experimental
and removed
PR use: In Beta / Experimental
labels
Following the I2I issue #24879, this PR adds Sirdata to the list of “Supported Consent Management Platforms” in the
amp-consentextension.Here’s an example of basic integration: https://cmp.sirdata.com/demo/amp.html
The example will be updated with the advanced integration once validated by AMP.
Corporate CLA signed since 11/21 for Sirdata linked to rde@sirdata.fr
Reference to @ampproject/wg-monetization
@tla-sirdata will maintain Sirdata AMP implementation.
Also fix a minor typo in css example file examples/amp-consent/cmp-vendors.amp.html