Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-next-page-v2: better manual tests #26099

Merged
merged 6 commits into from
Jan 13, 2020
Merged

amp-next-page-v2: better manual tests #26099

merged 6 commits into from
Jan 13, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Dec 19, 2019 •
edited
Loading

Changes

  • Improves manual tests with better articles
  • Minor cleanup

@wassgha wassgha changed the title amp-next-page-v2: visual diff tests and better manual tests amp-next-page-v2: better manual tests Jan 10, 2020
@wassgha wassgha marked this pull request as ready for review January 10, 2020 11:36
@wassgha wassgha requested review from caroqliu and removed request for andrewwatterson January 10, 2020 11:37
@wassgha wassgha merged commit 062d33e into ampproject:master Jan 13, 2020
@wassgha wassgha deleted the amp-next-page-v2-visual-diff branch January 13, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wassgha @caroqliu @googlebot @ampprojectbot