Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️<amp-next-page> v2 minor renaming and fixes #26468

Merged
merged 28 commits into from
Jan 28, 2020
Merged

♻️<amp-next-page> v2 minor renaming and fixes #26468

merged 28 commits into from
Jan 28, 2020

Commits on Dec 19, 2019

  1. Added visual diff tests and better manual tests

    @wassgha
    wassgha committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    2c60f47 View commit details
    Browse the repository at this point in the history

  2. Prototyping sticky element handling in amp-next-page

    @wassgha
    wassgha committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    fd8de0d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into amp-next-page-v2-hide-elements

    @wassgha
    wassgha committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    5733c3e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into amp-next-page-v2-visual-diff

    @wassgha
    wassgha committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    35c9f61 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Deprecate amp-next-page-keep in favor of amp-next-page-hidden

    @wassgha
    wassgha committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    bac73c6 View commit details
    Browse the repository at this point in the history

  2. Visibility bug fix

    @wassgha
    wassgha committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    8295a33 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Remove animation added for testing

    @wassgha
    wassgha committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    bf9e8a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Exported host-page-specific parameters into HostPage

    @wassgha
    wassgha committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    2085a36 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into amp-next-page-v2-hide-elements

    @wassgha
    wassgha committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    aca949b View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Preventing next-page form building again

    @wassgha
    wassgha committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    72ce30f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into amp-next-page-v2-visual-diff

    @wassgha
    wassgha committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    3c38550 View commit details
    Browse the repository at this point in the history

  3. Remove visual diff tests

    @wassgha
    wassgha committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    d12c8c6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'amp-next-page-v2-visual-diff' into amp-next-page-v2-inf… 

    …inite-loading
    @wassgha
    wassgha committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    0a35078 View commit details
    Browse the repository at this point in the history

  5. Implement infinite loading for amp-next-page v2

    @wassgha
    wassgha committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    81a3e93 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Merge branch 'master' into amp-next-page-v2-infinite-loading

    @wassgha
    wassgha committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    63b4407 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Implements un-loading and re-loading pages to reduce memory footprint

    @wassgha
    wassgha committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    8065574 View commit details
    Browse the repository at this point in the history

  2. Added unit tests

    @wassgha
    wassgha committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    3959e56 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Fixes types

    @wassgha
    wassgha committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6fb9245 View commit details
    Browse the repository at this point in the history

  2. Implemented a default separator pill and templating for the separator

    @wassgha
    wassgha committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6a55cff View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Types fix

    @wassgha
    wassgha committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    5bf5fd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Merge branch 'master' into amp-next-page-v2separators

    @wassgha
    wassgha committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    d3ab4cb View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Fix tests for renaming

    @wassgha
    wassgha committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    2f19d18 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into amp-next-page-v2separators

    @wassgha
    wassgha committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    542cc2d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Added unit tests for separators

    @wassgha
    wassgha committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    2c1a9aa View commit details
    Browse the repository at this point in the history

  2. Fix types

    @wassgha
    wassgha committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    909bb9e View commit details
    Browse the repository at this point in the history

  3. Preserve only name changes and fixes

    @wassgha
    wassgha committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    e9dea23 View commit details
    Browse the repository at this point in the history

  4. Suggested fixes

    @wassgha
    wassgha committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    22c840a View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Merge branch 'master' into amp-next-page-renaming

    @wassgha
    wassgha committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7077068 View commit details
    Browse the repository at this point in the history