Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨amp-nested-menu: allow svg into #26502

Merged
merged 3 commits into from
Jan 27, 2020
Merged

✨amp-nested-menu: allow svg into #26502

merged 3 commits into from
Jan 27, 2020

Conversation

catherinehoule
Copy link
Contributor

@catherinehoule catherinehoule commented Jan 27, 2020 •
edited
Loading

fixes #26463

@amp-owners-bot amp-owners-bot bot requested a review from nainar January 27, 2020 16:38
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

wassgha
wassgha suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@wassgha wassgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @catherinehoule ! Thank you for your contribution! I believe you might have accidentally renamed the file to allow-svg-to-amp-nested-menu (should be validator-amp-nested-menu.protoascii), could you please revert that change? Otherwise should be good!

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-nested-menu/validator-amp-nested-menu.protoascii

@catherinehoule
Copy link
Contributor Author

@wassgha omg you are right, what a dumb mistake! I fixed it... Sorry about that.
Thanks for quick review.

wassgha
wassgha approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@wassgha wassgha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Heads up that validator changes usually will take around 2 weeks to propagate!

@wassgha wassgha merged commit f7f88a6 into ampproject:master Jan 27, 2020
@catherinehoule catherinehoule deleted the patch-1 branch January 28, 2020 16:52
westonruter added a commit to westonruter/amphtml that referenced this pull request Jan 28, 2020
@westonruter
Merge branch 'master' of github.com:ampproject/amphtml into add/amp-i…
2b6e016 
…frame-pymjs-support

* 'master' of github.com:ampproject/amphtml: (436 commits)
  🐛Add computed styles to fake win (ampproject#26514)
  📦 Update dependency eslint-config-prettier to v6.10.0 (ampproject#26518)
  🐛 Rewrite relative urls in the bookend (ampproject#26490)
  ✨ [amp-list] Introduce "amp-state:" as a usable protocol for the src attribute. (ampproject#26284)
  Add terminal newline to files.txt (ampproject#26513)
  📦 Update dependency chromedriver to v79.0.2 (ampproject#26515)
  ♻️ Change the opt-in cookie values to reflect upcoming CDN changes (ampproject#26489)
  ♻️<amp-next-page> v2 minor renaming and fixes (ampproject#26468)
  fix link (ampproject#26508)
  amp-list: fix broken test re. missing layout (ampproject#26509)
  performance: emit timeOrigin w/ polyfill (ampproject#26485)
  Position n+1 story desktop page before positioning attributes are set. (ampproject#26488)
  ✨amp-nested-menu: allow svg into (ampproject#26502)
  Log user warning when missing URL arg for shadow doc (ampproject#26290)
  📦 Update dependency puppeteer to v2.1.0 (ampproject#26501)
  Ensure that fluid slots hidden by media queries do not issue ad requests. (ampproject#26352)
  📦 Update dependency mocha to v7.0.1 (ampproject#26495)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  ...
twifkak pushed a commit to twifkak/amphtml that referenced this pull request Feb 4, 2020
@twifkak
cl/291956471 Revision bump for ampproject#26502
5258c7f
@twifkak twifkak mentioned this pull request Feb 4, 2020
Merged
twifkak added a commit that referenced this pull request Feb 5, 2020
@twifkak @Gregable
Validator rollup (#26621)
dea7576 
* cl/291956471 Revision bump for #26502

* cl/293201160 Revision bump for #26598

Co-authored-by: Greg Grothaus <ggrothau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wassgha wassgha wassgha approved these changes

@nainar nainar Awaiting requested review from nainar

Assignees
No one assigned
Labels
cla: yes PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow 'svg' as a descendant of of tag 'amp-nested-menu'.
4 participants
@catherinehoule @googlebot @wassgha @ampprojectbot