Validator Roll-up #2711
Merged
Validator Roll-up #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css_selectors namespace -> parse_css namespace for consistency with tokenize-css.js and parse-css.js. SelectorNode -> Selector and NodeVisitor -> SelectorVisitor, since in the parse_css namespace this is less ambiguous. line / cols in constructor arguments gone for consistency with the other classes. parse -> parseSelectors, traverse -> traverseSelectors to reduce ambiguity in parse_css namespace.
…ULE. This should make it clearer. Since the translations aren't used yet, and this is specifically to address a question someone had, I think it's fine to update this. If someone complains, I'll roll it back later.
This cl makes allowances as specified by the grammar, for each of these S*. https://www.w3.org/TR/css3-selectors/#grammar attrib : '[' S* [ namespace_prefix ]? IDENT S* [ [ PREFIXMATCH | SUFFIXMATCH | SUBSTRINGMATCH | '=' | INCLUDES | DASHMATCH ] S* [ IDENT | STRING ] S* ]? ']' ;
Sorry I forgot to add this earlier.
This will be a compiler error soon.
…n HTML test case. If you add the attribute `data-amp-report-test` to a tag, any errors emitted regarding that tag will have a new field dataAmpReportTestValue which will contain the attribute value set in the document. Example: `<!doctype lemur data-amp-report-test="foo">` results in a validationResult object whose errors array looks like: `errors[0].dataAmpReportTestValue -> 'foo'` Github #2600
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
@honeybadgerdontcare @powdercloud for review |
|
@googlebot confirmed |
|
@googlebot confirmed |
|
@erwinmombay as well. googlebot wants you to confirm that you authored the commit that I'm pulling on your behalf. Also, you will want this for release notes. |
This was referenced Mar 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes affecting PASS/FAIL:
<a rel="noopener">. Github Validator: Add support for rel="noopener" #2641<amp-list>. Github Validation error if amp-list references an template #2517<amp-social-share>./but don't form a closing tag.