Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator rollup at 450/1022 #27279

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Validator rollup at 450/1022 #27279

merged 5 commits into from
Mar 18, 2020

Conversation

amaltas
Copy link
Contributor

@amaltas amaltas commented Mar 18, 2020

No description provided.

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

extensions/amp-list/0.1/test/validator-amp-list.out
validator/validator-main.protoascii

@amaltas amaltas added WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required. WG: caching and removed WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required. labels Mar 18, 2020
honeybadgerdontcare
honeybadgerdontcare requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be duplicative. Perhaps revert this file gut keeping validator-main.protoascii.

@amaltas
Copy link
Contributor Author

amaltas commented Mar 18, 2020

This appears to be duplicative. Perhaps revert this file gut keeping validator-main.protoascii.

Removed the duplicates in the review tool.

@amaltas amaltas merged commit e8b094d into ampproject:master Mar 18, 2020
twintwox pushed a commit to twintwox/amphtml that referenced this pull request Mar 24, 2020
@amaltas @twintwox
Validator rollup at 450/1022 (ampproject#27279)
65ab297 
* cl/301228504 Revision bump for ampproject#27083

* cl/301306664 Revision bump for ampproject#27180

* Update validator-amp-list.out

* Update validator-amp-list.out

* Update validator-amp-list.out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaltas @honeybadgerdontcare @googlebot @ampprojectbot