add live-list poller #2790
add live-list poller #2790
Conversation
|
@dvoytenko PTAL |
| return; | ||
| } | ||
| if (this.lastBackoffTimeoutId_) { | ||
| this.win.clearTimeout(this.lastBackoffTimeoutId_); |
There was a problem hiding this comment.
Add this.lastBackoffTimeoutId_ = null; after clearing it.
There was a problem hiding this comment.
done. also added tests
erwinmombay
force-pushed
the
poller
branch
6 times, most recently
from
e260328
to
ced61e0
Compare
|
@dvoytenko PTAL, ready for review again. |
| * The poller is running but is doing exponential backoff (using | ||
| * the original interval value as base) every tick. | ||
| */ | ||
| BACKEDOFF: 'backedoff', |
There was a problem hiding this comment.
Not sure how useful this state is. From a point of view of the poller itself: it can be either running or not running, right? And it can be either in normal mode or recovery mode. But it depends on how you intend the PollerState enum to be used - if it's mostly for internal/testing purposes, it's certainly fine.
erwinmombay
force-pushed
the
poller
branch
3 times, most recently
from
953a250
to
3c4c2ea
Compare
erwinmombay
force-pushed
the
poller
branch
2 times, most recently
from
5b75245
to
9dee506
Compare
|
@dvoytenko PTAL. ready for review again |
| * Polling state of a Poller instance. | ||
| * @enum {string} | ||
| */ | ||
| export const PollerState = { |
There was a problem hiding this comment.
This looks like a binary state now - so a simple boolean would do :)
|
@erwinmombay Looks great. Just a few requests, but pretty close to LGTM. |
|
@dvoytenko addressed last rounds of comments. PTAL |
|
LGTM |
@dvoytenko poller review here