Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗Make babel plugin tests work with jest v25 #28002

Merged
merged 2 commits into from
Apr 24, 2020
Merged

🏗Make babel plugin tests work with jest v25 #28002

merged 2 commits into from
Apr 24, 2020

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Apr 23, 2020

The latest version of jest (v25) introduces a breaking change in the CLI that makes it incompatible with gulp-jest. See #27973 (comment).

This PR does a minor refactor of AMP babel plugin tests and eliminates the use of gulp-jest in favor of directly using the jest CLI, which is now shipped as part of @jest/core.

image

References:

Addresses #27973 (comment).
Closes #27973

@rsimha
Copy link
Contributor Author

rsimha commented Apr 23, 2020

This change worked. Will merge after Travis is green.

@rsimha rsimha merged commit c619be8 into ampproject:master Apr 24, 2020
@rsimha rsimha deleted the 2020-04-23-BabelPluginTests branch April 24, 2020 00:34
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants