amp-sidebar - Whitelist checks and Documentation. #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,8 +16,9 @@ | |||
|
|
|||
| import {CSS} from '../../../build/amp-sidebar-0.1.css'; | |||
| import {Layout} from '../../../src/layout'; | |||
| import {isExperimentOn} from '../../../src/experiments'; | |||
| import {assert} from '../../../src/asserts'; | |||
There was a problem hiding this comment.
Please no longer use assers.js - user user from log.js instead.
camelburrito
force-pushed
the
sidebar_whitelist
branch
from
a0556fd
to
c1cee55
Compare
|
PTAL |
camelburrito
force-pushed
the
sidebar_whitelist
branch
2 times, most recently
from
a485073
to
0b953ed
Compare
| @@ -23,6 +23,72 @@ limitations under the License. | |||
| </tr> | |||
| <tr> | |||
| <td width="40%"><strong>Availability</strong></td> | |||
| <td><div>Experimental</div><div>Work in progress.</div></td> | |||
| <td><div><a href="https://www.ampproject.org/docs/reference/experimental.html">Experimental</a>; no validations yet.</div><div>Work in progress.</div></td> | |||
There was a problem hiding this comment.
Looks like at this point we can already file the validator request, right?
There was a problem hiding this comment.
Looks like the changes are already on goldmine :) ill have to file bugs for some minor changes.
|
One significant change requested to improve scan. Otherwise, LGTM. |
camelburrito
force-pushed
the
sidebar_whitelist
branch
3 times, most recently
from
8b4ff2e
to
d4608fe
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.