Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use amp-elements for creating dynamic placeholders during buildCallback. #2846

Merged
merged 10 commits into from
May 6, 2016
Merged

Use amp-elements for creating dynamic placeholders during buildCallback. #2846

merged 10 commits into from
May 6, 2016

Commits on May 5, 2016

  1. Use amp-elements for creating dynamic placeholders during buildCallback.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    fb5982d View commit details
    Browse the repository at this point in the history

  2. Implement buildPlaceholderCallback for dynamic placeholders.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    b15a974 View commit details
    Browse the repository at this point in the history

  3. Reverting to YouTube hack

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    62c0819 View commit details
    Browse the repository at this point in the history

  4. Hide all placeholders.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    ec5bc0c View commit details
    Browse the repository at this point in the history

  5. Add tests cases.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    2f36b0b View commit details
    Browse the repository at this point in the history

  6. Increase amp-element count in integration tests.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    054c45f View commit details
    Browse the repository at this point in the history

  7. Address comments on PR.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    2c643f5 View commit details
    Browse the repository at this point in the history

  8. use layout=fill

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    1e55e3e View commit details
    Browse the repository at this point in the history

  9. move placeholder toggling to resources.

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    1611d76 View commit details
    Browse the repository at this point in the history

  10. fix lint and presubmit

    @mkhatib
    mkhatib committed May 5, 2016
    Configuration menu
    Copy the full SHA
    672106c View commit details
    Browse the repository at this point in the history