Log current state and element with error report during broken layout flow #29088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Jun 30, 2020
| ); | ||
| reportError(err, this.element); | ||
| err.associatedElement = this.element; | ||
| reportError(err); | ||
| return Promise.reject(err); |
There was a problem hiding this comment.
Yes. The worse case is that the element is deferred to a second pass. But as soon as it goes through the flow correctly, it will do layout.
jridgewell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error report isn't giving enough information for me to properly debug this. So, I'm now logging the current state, and attaching the associated element the element so the tagname is also reported.