add version to ModeDef #2918
Merged
add version to ModeDef #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
pass-full-version
branch
from
373a434
to
2c0bc01
Compare
|
@cramforce PTAL |
| return { | ||
| localDev: isLocalDev, | ||
| // Triggers validation | ||
| development: developmentQuery['development'] == '1' || window.AMP_DEV_MODE, | ||
| minified: process.env.NODE_ENV == 'production', | ||
| test: window.AMP_TEST, | ||
| log: developmentQuery['log'], | ||
| version: version, |
There was a problem hiding this comment.
Lets remove this. We version lock the child frame, so it can read this itself, and we need to be careful with the URL length.
There was a problem hiding this comment.
got it, will rename fullVersion to just version
erwinmombay
force-pushed
the
pass-full-version
branch
3 times, most recently
from
5985219
to
90c3b15
Compare
| return win.AMP_CONFIG.fullVersion; | ||
| } | ||
|
|
||
| const selector = 'script[src$="/v0.js"]'; |
There was a problem hiding this comment.
When do we need this code path?
There was a problem hiding this comment.
so right now we don't have win.AMP_CONFIG.fullVersion so this is to look for v0.js and read the version from the script tags src when the page is on the cache. I should implement #2917 by EOD. so you're right im not sure we need it. let me know what you think.
There was a problem hiding this comment.
removed.
added win.AMP_CONFIG.v during build
erwinmombay
force-pushed
the
pass-full-version
branch
2 times, most recently
from
88607b5
to
8d1cf11
Compare
|
@cramforce PTAL |
erwinmombay
force-pushed
the
pass-full-version
branch
from
8d1cf11
to
107a2ea
Compare
erwinmombay
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2874