Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first version of amp-onetap-google component #29247

Merged
merged 14 commits into from
Aug 29, 2020
Merged

first version of amp-onetap-google component #29247

merged 14 commits into from
Aug 29, 2020

Conversation

kongguibin
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kongguibin kongguibin marked this pull request as draft July 13, 2020 17:38
@nainar
Copy link
Contributor

nainar commented Jul 13, 2020

Assigining to @wassgha for review

@nainar nainar requested a review from wassgha July 13, 2020 22:04
@nainar
Copy link
Contributor

nainar commented Jul 24, 2020

@kongguibin is there an update here?

@kongguibin kongguibin force-pushed the onetap branch 3 times, most recently from c37d6b0 to 3606578 Compare August 7, 2020 01:00
@nainar
Copy link
Contributor

nainar commented Aug 19, 2020

@alanorozco to review.

@kongguibin kongguibin marked this pull request as ready for review August 28, 2020 17:42
@google-cla
Copy link

google-cla bot commented Aug 28, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 28, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kongguibin
Copy link
Contributor Author

@googlebot I fixed it.

@kongguibin kongguibin force-pushed the onetap branch 3 times, most recently from 679e7c1 to 7fc15b2 Compare August 28, 2020 21:39
@alanorozco alanorozco merged commit 2fda798 into ampproject:master Aug 29, 2020
@nainar nainar mentioned this pull request Sep 3, 2020
Closed
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@kongguibin @ed-bird
first version of amp-onetap-google component (ampproject#29247)
7d94631
@ampprojectbot ampprojectbot mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpettitt jpettitt jpettitt left review comments

@alanorozco alanorozco alanorozco approved these changes

@kristoferbaxter kristoferbaxter Awaiting requested review from kristoferbaxter

@wassgha wassgha Awaiting requested review from wassgha

@dvoytenko dvoytenko Awaiting requested review from dvoytenko

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kongguibin @googlebot @nainar @alanorozco @jpettitt @ampprojectbot