Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ad iframe _after_ registering listeners #2942

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Append ad iframe _after_ registering listeners #2942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtins/amp-ad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ export function installAd(win) {
this.element);
this.iframe_.setAttribute('scrolling', 'no');
this.applyFillContent(this.iframe_);
this.element.appendChild(this.iframe_);
this.intersectionObserver_ =
new IntersectionObserver(this, this.iframe_, /* opt_is3P */true);
// Triggered by context.noContentAvailable() inside the ad iframe.
Expand Down Expand Up @@ -280,6 +279,7 @@ export function installAd(win) {
this.viewer_.onVisibilityChanged(() => {
this.sendEmbedInfo_(this.isInViewport());
});
this.element.appendChild(this.iframe_);
return loadPromise(this.iframe_);
});
}
Expand Down