amp-script: Move [nodom] CSS to ampdoc.css to avoid resize #29752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Aug 7, 2020
| amp-script[nodom] { | ||
| /* Fixed to make position independent of page other elements. */ | ||
| position: fixed !important; | ||
| top: 0 !important; |
There was a problem hiding this comment.
why do we need to specify top/overflow?
There was a problem hiding this comment.
This aligns with CSS for amp-analytics. My guess is top helps make sure it's in viewport to be laid out, not sure about overflow.
There was a problem hiding this comment.
I left it out because they didn't seem necessary 🤷
jridgewell
approved these changes
Aug 11, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…t#29752) * Move amp-script[nodom] CSS to ampdoc.css. * Unskip test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29733 (comment).