Increase timeout for all amp-facebook tests for flakieness #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, the irony of it flaking again. 😅 |
|
argh. You think FB is just blocking our travis IPs or something? |
| @@ -20,7 +20,9 @@ import {adopt} from '../../../../src/runtime'; | |||
|
|
|||
| adopt(window); | |||
|
|
|||
| describe('amp-facebook', () => { | |||
| describe('amp-facebook', function() { | |||
There was a problem hiding this comment.
This is fine, but I think we should consider, uhm, reducing the test coverage here :)
There was a problem hiding this comment.
yeah. agreed. I think overall third party rendering seems flakey so maybe worth visiting to mock out of the tests.
|
File a bug against yourself to do a permanent fix with proper stubs |
|
Done #3037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just taking this up a notch for all FB elements. Previously increased for a single test case #2904