add amp-live-list manager #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
amp-live-list-manager
branch
2 times, most recently
from
29211fe
to
c1f6a9f
Compare
|
@dvoytenko PTAL |
erwinmombay
force-pushed
the
amp-live-list-manager
branch
4 times, most recently
from
e8cba50
to
e49b2ab
Compare
|
cc @cramforce |
| // Polling should always be stopped when document is no longer visible. | ||
| this.viewer_.onVisibilityChanged(() => { | ||
| if (this.viewer_.isVisible()) { | ||
| this.poller_.start(); |
There was a problem hiding this comment.
Does this trigger an immediate invocation?
There was a problem hiding this comment.
it does not, it would queue up a timeout (with jitter).
There was a problem hiding this comment.
The design doc says to do it, so that the time since last poll is taken into account.
I think that is pretty important. Basically when you return to a page after 5 minutes you want an immediate update.
There was a problem hiding this comment.
makes sense, will fix
There was a problem hiding this comment.
added opt_isLeading param to start.
|
Looks great. A few questions/comments. |
erwinmombay
force-pushed
the
amp-live-list-manager
branch
4 times, most recently
from
c744338
to
53192c9
Compare
| // Polling should always be stopped when document is no longer visible. | ||
| this.viewer_.onVisibilityChanged(() => { | ||
| if (this.viewer_.isVisible()) { | ||
| this.poller_.start(true); |
There was a problem hiding this comment.
Add comment for what the true means.
erwinmombay
force-pushed
the
amp-live-list-manager
branch
2 times, most recently
from
a3534a0
to
b6ac7ea
Compare
|
@cramforce PTAL |
|
LGTM |
erwinmombay
force-pushed
the
amp-live-list-manager
branch
from
b6ac7ea
to
e09457d
Compare
erwinmombay
force-pushed
the
amp-live-list-manager
branch
from
e09457d
to
5764bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add amp-live-list manager that handles the request/response cycle if there are multiple amp-live-list instances on a document.