Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass down the parent URL to disable glade in doubleclick test #3102

Merged
merged 1 commit into from
May 5, 2016

Conversation

mkhatib
Copy link
Contributor

@mkhatib mkhatib commented May 4, 2016

As @cramforce suggested, this is the quickest way to fix the doubleclick integration test.

Fixes #3001

cc/ @erwinmombay

@cramforce
Copy link
Member

Does this work? Just making sure :)

@mkhatib
Copy link
Contributor Author

mkhatib commented May 5, 2016

Yes 💃 But the flake gods are not with me right now - restarting the build.

@cramforce
Copy link
Member

LGTM

@mkhatib mkhatib merged commit 45ff453 into ampproject:master May 5, 2016
@mkhatib mkhatib deleted the fix-doubleclick-test branch May 5, 2016 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix local ad test that is failing
2 participants