Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag GLADE opt out requests with tracking experiment id. #3111

Merged
merged 1 commit into from
May 10, 2016

Conversation

mlb7687
Copy link
Contributor

@mlb7687 mlb7687 commented May 5, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jridgewell
Copy link
Contributor

LGTM.

@@ -18,6 +18,16 @@ import {loadScript, checkData} from '../../src/3p';
import {getCorrelator} from './utils';

/**
* @enum{number}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mlb7687
Copy link
Contributor Author

mlb7687 commented May 6, 2016

I signed it!

@jridgewell
Copy link
Contributor

Ping @erwinmombay: I believe you can merge without status checks passing? @googlebot seems to be on the fritz.

@mlb7687
Copy link
Contributor Author

mlb7687 commented May 9, 2016

Ping @erwinmombay to merge this change. Not sure why googlebot is giving this warning.

@jridgewell jridgewell assigned erwinmombay and unassigned jridgewell May 10, 2016
@erwinmombay erwinmombay merged commit 745dee0 into ampproject:master May 10, 2016
@erwinmombay
Copy link
Member

sorry for delay, didnt see email. merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants