-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag GLADE opt out requests with tracking experiment id. #3111
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
LGTM. |
@@ -18,6 +18,16 @@ import {loadScript, checkData} from '../../src/3p'; | |||
import {getCorrelator} from './utils'; | |||
|
|||
/** | |||
* @enum{number} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I signed it! |
Ping @erwinmombay: I believe you can merge without status checks passing? @googlebot seems to be on the fritz. |
Ping @erwinmombay to merge this change. Not sure why googlebot is giving this warning. |
sorry for delay, didnt see email. merged! |
No description provided.