🧪Introduce ads experiment for intersect-resources #31253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: |
|
Thanks for starting the experiment! |
dvoytenko
suggested changes
Nov 18, 2020
dvoytenko
approved these changes
Nov 18, 2020
jridgewell
requested changes
Nov 18, 2020
jridgewell
approved these changes
Nov 19, 2020
dvoytenko
approved these changes
Nov 19, 2020
lannka
approved these changes
Nov 19, 2020
|
@samouri could you please approve, looks like Justin's approval was before bundle-size bot finished and he is now OOO. |
samouri
approved these changes
Nov 19, 2020
erwinmombay
approved these changes
Nov 19, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* add exp * fix dep-check * move to own file * don't let ads set exp * only report inob eligible
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine impact of known issue.
cc/ @jeffkaufman